Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/20784 )
Change subject: rpci: Use pci_dev struct pointer to avoid API breaks ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/20784/1/pcidev.c File pcidev.c:
https://review.coreboot.org/#/c/20784/1/pcidev.c@262 PS1, Line 262: struct pci_dev * dev;
No whitespace after the asterisk, please.
oups, I noticed it but forgot to fix it.
https://review.coreboot.org/#/c/20784/1/pcidev.c@297 PS1, Line 297:
Add a comment that `dev` passed to rpci_* has to be compatible
Added in the header file. The code was already checking for validity of 'pacc', so it was already a requirement before my change, but I've changed things to make it more robust.
https://review.coreboot.org/#/c/20784/1/pcidev.c@307 PS1, Line 307: a->domain, a->bus, a->dev, a->func); \
Bail out if `undo_pci_write_data->dev` is NULL or check it
Done
-
Youness Alaoui (Code Review)