Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52364 )
Change subject: programmer.h,chipset_enable.c: Make penable cb more descript ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52364/comment/b9912f28_0edb9a88 PS1, Line 7: Make penable cb more descript Maybe it's just me, but `cb` resolves to `coreboot`. How about:
Rename penable callback
https://review.coreboot.org/c/flashrom/+/52364/comment/537cdc12_f7bb2356 PS1, Line 15: use typo use*d*
File programmer.h:
https://review.coreboot.org/c/flashrom/+/52364/comment/87bff6ba_275817c9 PS1, Line 228: enable_flash_xxx
What does xxx mean here? Maybe there is the reason for xxx? Is it possible to have the function name […]
I'd prefer `enable_flash` too.