Change in flashrom[master]: meson.build: Don't depend on getrevision.sh - flashrom-gerrit

17 Feb 2022


      Attention is currently required from: Nico Huber, powpowd@gmail.com.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 )
Change subject: meson.build: Don't depend on getrevision.sh
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62061/comment/0784532a_60bc2525 
PS3, Line 9: (including
           : GitHub's auto-generated tarballs and ZIPs)
Why would anyone use those? We have signed release tarballs (e.g. https://www.flashrom.org/Latest_release for the latest release) and non-release builds should be done using a `git clone` so that the version is properly reported (e.g. `v1.2-422-g529dc1e`).
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62061
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16
Gerrit-Change-Number: 62061
Gerrit-PatchSet: 3
Gerrit-Owner: powpowd@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: powpowd@gmail.com
Gerrit-Comment-Date: Thu, 17 Feb 2022 14:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment