Change in flashrom[master]: tests: use MOCK_FD instead of NON_ZERO - flashrom-gerrit

4 Apr 2022


      Attention is currently required from: Daniel Campello, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63193 )
Change subject: tests: use MOCK_FD instead of NON_ZERO
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63193/comment/e94e84fb_9b272e60 
PS3, Line 9: return a non-negative value for
           : the file descriptor expected from open operations.
...
This could not be intentional. […]
Well that is exactly why I was wondering if it was intentional? i.e., to fail if there is no `open()` mocked in a test.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63193
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib6bac051852aea2465665a6fd669b7f5e3772985
Gerrit-Change-Number: 63193
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Campello campello@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 04 Apr 2022 02:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Daniel Campello campello@chromium.org
Gerrit-MessageType: comment