Attention is currently required from: Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56799 )
Change subject: realtek_mst_i2c_spi: don't always fail init
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56799/comment/3215ab2c_ac470169
PS1, Line 14: Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1
+1
Done
Patchset:
PS1:
I got confused at first because even initial version of this file has `int ret = SPI_GENERIC_ERROR;` […]
Added.
PS1:
well it was being used until it got re-implemented in fwupd right.
No, we've never used this in production (yet).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1
Gerrit-Change-Number: 56799
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 05 Aug 2021 01:45:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment