Attention is currently required from: Matt DeVillier.
Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email )
Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: I have one last comment and that should be it.
Thank you for your work, you took years old patch and finished it! Much appreciated.
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/85159/comment/d6e112c8_b94eb07b?usp... : PS4, Line 1341: * Common rules for -r/-w/-v syntax parsing: I really like this comment, and I would copy it into the manpage. Same text (just need to remove the asterisks). The users won't read the source code, but they might read the manpage and learn command line syntax.
Specifically, I would copy this text just before line 209 which says "Examples". So just before Examples, maybe call it "Summary" and then full text of this comment.
And also I would leave it here too. Thank you!