Attention is currently required from: Martin L Roth, Thomas Heijligen, Arthur Heymans.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 )
Change subject: flashrom: rename sb600spi.c to amd_spi.c ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The promontary support works well in that patch series linked. […]
Thinking a bit more about it, and returning back to the point of the patch. I like amd_spi.c more than amd_sb600_spi.c : it's a shorter name without loss of information. Commit message explains that "sb600" doesn't give any information, so why keep it in the name?
So I support renaming to amd_spi.c
(what is going on on the other forks is not that relevant for this question)
And I am still interested if there are any longer term plans that maybe Martin you have?
-
Anastasia Klimchuk (Code Review)