Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58103 )
Change subject: tests: Add wraps for __xstat variants of stat ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5: I decided to re-test once again after the patch got approved, and discovered that now the same thing is needed for fstat :\ Specifically for read_chip and read_chip_with_dummyflasher, the same situation: fstat64 is invoked when running ninja test, and __fxstat64 is invoked when emerge with tests under chroot.
Are stat and fstat sufficiently close to each other so they can be counted as solution to the same problem? Because Nico said:
I hope this will not turn into a cat-and-mouse game where we'd have to add more wraps in the future. But if it does: we could try to mock the header file as well.
I don't know whether this moment has happened or not yet.
Leaving comment unresolved.
-
Anastasia Klimchuk (Code Review)