Change in flashrom[staging]: chipset_enable: Add support for Intel Skylake / Kabylake - flashrom-gerrit

12 Jun 2017


      Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/18925 )
Change subject: chipset_enable: Add support for Intel Skylake / Kabylake
......................................................................
Patch Set 5:
One issue I'm having with this code is that it will segfault at the end.
I've tracked it down to the rpci_write_byte in enable_flash_ich_bios_cntl_common which calls register_undo_pci_write_byte which saves a copy of the pci device, but the copy is wrong (pci accessor is somehow set to -1) and it segfaults when it tries to restore the pci register in the shutdown handlers.
I'm not yet sure how to properly fix this.
-- 
To view, visit https://review.coreboot.org/18925
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I000819aff25fbe9764f33df85f040093b82cd948
Gerrit-Change-Number: 18925
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: Youness Alaoui snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Jun 2017 22:24:45 +0000
Gerrit-HasComments: No