Attention is currently required from: Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58357 )
Change subject: tests: Add tests to write on chip
......................................................................
Patch Set 3:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/58357/comment/d17081d0_9a1527d8
PS2, Line 270: flash
Although it would be nice to have `struct flashromctx ctx = { 0 };` sort of future, see https://gith […]
Thank you! I agree with future idea.
For now, I did option #2, next patch CB:58596
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58357
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6f0336613ab16a7e59857006496e3590ddb14d00
Gerrit-Change-Number: 58357
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 26 Oct 2021 03:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment