Attention is currently required from: Thomas Walker, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 )
Change subject: flashchips: Add Spansion/Cypress S25FL256L ......................................................................
Patch Set 6:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52310/comment/cdabb3aa_215be900 PS5, Line 16387: FEATURE_4BA
Forgive me if I'm incorrect, but in the datasheet there is a section: 6.1.1 Extended Address […]
Yes, two ways. Not three. :)
Often there is a third way to access the space above 16MiB. The extended address register (EAR) works like a page selection. If you leave it at 0, you can access the first 16MiB with 24-bit address commands, if you set it to 1, you can access the second 16MiB and so on. Or in other words, internally the 32-bit address is composed of
<EAR> | <24-bit from command>
Maybe `FEATURE_4BA_EXT_ADDR` is a bit confusing and should be renamed? Other vendors don't use the term "extended address" unless they refer to this particular register.
-
Nico Huber (Code Review)