Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons, Anastasia Klimchuk.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce HSFC_FCYCLE_MASK(n) macro
......................................................................
Patch Set 8:
(3 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/e393bd74_4a2bfa25
PS6, Line 88: Changed HSFC Control bits
These are register fields that changed with Sunrise Point, please keep things […]
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/4409546d_030917fa
PS6, Line 147: 4K
Not always 4K.
Ack
https://review.coreboot.org/c/flashrom/+/62891/comment/a412a26b_14930c08
PS6, Line 150: /*
: * 4 bits to represents the FCYCLE operation for PCH as:
: * 0: SPI Read
: * 2: SPI Write
: * 3: SPI Erase 4K
: * 4: SPI Erase 64K
: * 6: SPI RDID
: * 7: SPI Write Status
: * 8: SPI Read Status
: */
: #define HSFC_FCYCLE_BIT_WIDTH_PCH 0xf
Please don't mix ICH9 with PCH100 definitions.
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id222304165610c7ae48e365d72ec8fdeea51c51d
Gerrit-Change-Number: 62891
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 07 Apr 2022 18:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment