Attention is currently required from: Sam McNally.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63227 )
Change subject: tests: assert pathname and flags when calling open()
......................................................................
Patch Set 6:
(2 comments)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/63227/comment/a404b6ba_abd3579a
PS6, Line 77: wrap_open_and_friends
this may have unexpected behavior when `(get_io()->open != NULL)&&(get_io()->open_state != NULL)`.
open_state in not used when open != NULL (this function returns from within this if case)
https://review.coreboot.org/c/flashrom/+/63227/comment/19990c0d_b3d6b86e
PS6, Line 81: )
`&& !get_io()->open)`
see above
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63227
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib46ca5b854c8453ec02ae09f3151cd4d25f988eb
Gerrit-Change-Number: 63227
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Sat, 02 Apr 2022 13:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment