Attention is currently required from: Angel Pons, Nicholas Chin.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71066 )
Change subject: ch347t_spi.c: Move ch347_device struct to flashctx ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: Nicholas, thank you so much for removing global state! I have a question: is there any way this can be squashed with the previous patch? So that new programmer would be introduced without global state from the very beginning? We are currently actively removing global state from everywhere in flashrom (although some bits left still). For new programmer, I would try as much as possible to introduce it without global state.
You can use `Co-authored-by` tag in commit message to document that the patch is a collaboration of two engineers. In fact, I think you can use `Co-authored-by` anyway: it is already a collaboration ;)
-
Anastasia Klimchuk (Code Review)