Attention is currently required from: Alexander Goncharov, Edward O'Callaghan, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email )
Change subject: flashchips: change chip lock status funcs for Winbond chips
......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/75877/comment/7128be6d_2777334f :
PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I opened datasheets and looked up the function that allows to display all the data from the Status R […]
I agree with renaming, these names are long already so long name is fine. But new name will be actually more useful (self-documenting!)
The only thing I would change, is to have the order of registers in the order of how they are printed, which I think is: SRWD_SEC_TB_BP2_WELWIP
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75877?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49
Gerrit-Change-Number: 75877
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Sat, 15 Jul 2023 10:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment