Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63601 )
Change subject: raiden_debug_spi.c: Allow custom_rst param value of 'false'
......................................................................
Patch Set 2:
(1 comment)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/63601/comment/51c6dbae_a81a21ec
PS2, Line 1417: else if (!strcasecmp(custom_rst_str, "false"))
nit: All branches should use braces.
Fixed up, Thanks Angel.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63601
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I25bfe6f8e3f7cfffb1a9c99ac90ec56a750d7f84
Gerrit-Change-Number: 63601
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 05:39:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment