Attention is currently required from: Sam McNally, Nico Huber, Nicola Corna, Paul Menzel, Stefan Reinauer, David Hendricks, Daniel Campello, Arthur Heymans, Carl-Daniel Hailfinger.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 )
Change subject: layout: Add -i <region>[:<file>] support
......................................................................
Patch Set 27: Code-Review+2
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/23021/comment/0bbe6862_17c69124
PS27, Line 324: free(tempstr);
Extremely minor and sorry to be a bother, do you mind splitting out this leak fix into a separate patch?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/23021
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 27
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nicola Corna
nicola@corna.info
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006@gmx.net
Gerrit-Comment-Date: Thu, 15 Apr 2021 04:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment