[S] Change in flashrom[master]: tests/lifecycle: Run shutdown for init error paths

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67198 )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: tests/lifecycle: Run shutdown for init error paths
......................................................................

tests/lifecycle: Run shutdown for init error paths

`run_init_error_path` tests the scenario when init function of
a programmer fails. Init can fail at different phases and depending
on a specific test scenario it could be before or after shutdown
function has been registered.

If shutdown function has already been registered, it needs to run
because it cleans up the resources allocated during init. This patch
prevents memory leaks.

BUG=b:181803212
TEST=ninja test

Change-Id: I604edff18e35b7c044b73d3a8adfa8c800eddfd2
Signed-off-by: Anastasia Klimchuk 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67198
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Felix Singer 
Tested-by: build bot (Jenkins) 
---
M tests/lifecycle.c
1 file changed, 37 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Singer: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved

diff --git a/tests/lifecycle.c b/tests/lifecycle.c
index 11884f8..568b179 100644
--- a/tests/lifecycle.c
+++ b/tests/lifecycle.c
@@ -87,6 +87,17 @@
    assert_int_equal(error_code, flashrom_programmer_init(&flashprog, prog->name, param_dup));
    printf("... init failed with error code %i as expected\n", error_code);

+	/*
+	 * `flashrom_programmer_shutdown` runs only registered shutdown functions, which means
+	 * if nothing has been registered then nothing runs.
+	 * Since this is testing error path on initialisation and error can happen at different
+	 * phases of init, we don't know whether shutdown function has already been registered
+	 * or not yet. Running `flashrom_programmer_shutdown` covers both situations.
+	 */
+	printf("Running programmer shutdown in case anything got registered...\n");
+	assert_int_equal(0, flashrom_programmer_shutdown(flashprog));
+	printf("... completed\n");
+
    free(param_dup);

io_mock_register(NULL);