Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67072 )
Change subject: usb_device.c: release the usb interface on shutdown
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67072/comment/b28bbc9c_7a9958fd
PS2, Line 7: .
No period please
Done
https://review.coreboot.org/c/flashrom/+/67072/comment/80daf64d_0e350694
PS2, Line 10: handle.`
Where does this come from? I imagine it's from libusb documentation, so please mention it.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If916574314cd86fad3429065a11707da0a809e0d
Gerrit-Change-Number: 67072
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 01 Sep 2022 20:24:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment