Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/84775?usp=email )
Change subject: flashchips: Add Support for XMC XM25LU64C
......................................................................
Patch Set 2:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/84775/comment/4d40a318_75917613?usp... :
PS2, Line 22689: XM25LU64
Sorry I have only noticed just now: the name is missing "C" at the end (it's XM25LU64C). It is correct in other places (commit message and header file).
Could you please correct the name here too?
Everything else is fine. Thank you for testing both models.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84775?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8d1af7fbfb4c45db09ed5ac82c683d273c8151c7
Gerrit-Change-Number: 84775
Gerrit-PatchSet: 2
Gerrit-Owner: Ssunk
ssunkkan@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Ssunk
ssunkkan@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 19 Oct 2024 06:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No