Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email )
Change subject: Complete and fix progress feature implementation for all operations ......................................................................
Patch Set 10:
(3 comments)
File cli_output.c:
https://review.coreboot.org/c/flashrom/+/84102/comment/3336f656_a2ed4a37?usp... : PS9, Line 27: indicated nit: `to indicate`?
https://review.coreboot.org/c/flashrom/+/84102/comment/f3c838d4_586f3527?usp... : PS9, Line 33: enum last_printed_before_progress progress_separator nit: `enum line_state line_state`?
Progress is one of the possible states, but the variable itself is not exactly tied to the progress.
https://review.coreboot.org/c/flashrom/+/84102/comment/f6a7e16a_31d8eb64?usp... : PS9, Line 164: progress_separator = (fmt[strlen(fmt) - 1] == '\n' ? NEWLINE : MIDLINE); This and the analogous line below will have out of bounds access if the format string is empty.