[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ......................................................................
Patch Set 7:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/b72297f5_0d60f312 PS2, Line 1865: &mapper_phys
+1 regarding divide and conquer. […]
Yep Angel said it very well. Ideally if we can get to 'the new way' right at the very end of the series that is best. That way it is easy to bisect &| revert.
Recent story: Recently we worked on getting rid of the programmer parameter singleton pattern in flashrom.c I made sure to do all the refactoring so the switch over was right at the end assuming there was a devil hiding there. There definitely was!!! My first attempt needed to be reverted, Angel took another go at it and after one more patch after that we finally got there in the end. Because of all the global state in flashrom it is sometimes exceedingly hard to see where it will all explode despite everyone's best intentions. We just got to be a little particular about laying out the groundwork to avoid too much foot gun wrangling this map stuff but things are getting easier to manage step by step, thank you for working on this - a lot!!! :)
-
Edward O'Callaghan (Code Review)