Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )
Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip`
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69195/comment/c586b5b9_0e0ca9a4
PS2, Line 7: ichspi.c: Read chip ID and use it to identify chip
Maybe we should just print a warning if >1 chip is detected?
Subrata, do you have any thoughts on this?
Ideally as per descriptor, there can be 2 SPI flash and we need to drive CS PIN low to initiate the READ JEDEC ID (0x9F) HW seq command for each SPI flash chip to capture the response.
looking at the all latest platform, I don't see the usage of dual chips and mostly I could see the descriptor is set to 0 aka 1 chip.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6
Gerrit-Change-Number: 69195
Gerrit-PatchSet: 9
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 07:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment