[M] Change in flashrom[master]: serial: Add Darwin/macOS support for custom and >230400 baudrates - flashrom-gerrit

22 Dec 2022


      Attention is currently required from: Peter Stuge, Name of user not set #1004601.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70571 )
Change subject: serial: Add Darwin/macOS support for custom and >230400 baudrates
......................................................................
Patch Set 6:
(1 comment)
File serial.c:
https://review.coreboot.org/c/flashrom/+/70571/comment/b530261a_e6230a56 
PS4, Line 78: #if !IS_DARWIN
...
I understand that this can feel redundant. […]
I would prefer the variant in use_custom_baud(). So we don't reintroduce more IS_* macros
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70571
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3e6b88d2b4c2a130b16456752681fd9f807bf6f0
Gerrit-Change-Number: 70571
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Stuge peter@stuge.se
Gerrit-Reviewer: Name of user not set #1004601
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Peter Stuge peter@stuge.se
Gerrit-Attention: Name of user not set #1004601
Gerrit-Comment-Date: Thu, 22 Dec 2022 09:34:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Stuge peter@stuge.se
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment