Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.c: update copyright year ......................................................................
fmap.c: update copyright year
Looks like the year should be 2010 based on cros git history.
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: I7c27e682bd09f7b1ba0398dc231b9360aed1c26b --- M fmap.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/46440/1
diff --git a/fmap.c b/fmap.c index ca25651..494e9a8 100644 --- a/fmap.c +++ b/fmap.c @@ -1,5 +1,5 @@ /* - * Copyright 2015, Google Inc. + * Copyright 2010, Google Inc. * Copyright 2018-present, Facebook Inc. * All rights reserved. *
Nikolai Artemiev has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.c: update copyright year and name ......................................................................
fmap.c: update copyright year and name
Looks like the year should be 2010 based on cros git history.
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: I7c27e682bd09f7b1ba0398dc231b9360aed1c26b --- M fmap.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/46440/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.c: update copyright year and name ......................................................................
Patch Set 2:
Can you double check this with git blame to see what happened, I would favor the upstream from the downstream usually.
Hello build bot (Jenkins), Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/46440
to look at the new patch set (#3).
Change subject: fmap.{c,h}: update copyright year and name ......................................................................
fmap.{c,h}: update copyright year and name
Looks like the year should be 2010 based on cros git history.
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: I7c27e682bd09f7b1ba0398dc231b9360aed1c26b --- M fmap.c M fmap.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/46440/3
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.{c,h}: update copyright year and name ......................................................................
Patch Set 3:
Patch Set 2:
Can you double check this with git blame to see what happened, I would favor the upstream from the downstream usually.
It looks to me like 2010 is correct; the file was added to the cros tree by `commit 6d62d75b8b58a1a75`, which landed in 2011, but was uploaded in 2010 according to https://codereview.chromium.org/6025013.
I've also updated fmap.h in the newest patchset for the same reason.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.{c,h}: update copyright year and name ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3:
Patch Set 2:
Can you double check this with git blame to see what happened, I would favor the upstream from the downstream usually.
It looks to me like 2010 is correct; the file was added to the cros tree by `commit 6d62d75b8b58a1a75`, which landed in 2011, but was uploaded in 2010 according to https://codereview.chromium.org/6025013.
I've also updated fmap.h in the newest patchset for the same reason.
yes ok, I can see the upstream commit later added it here https://review.coreboot.org/23203
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.{c,h}: update copyright year and name ......................................................................
Patch Set 3: Code-Review+1
I'm not a lawyer.
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46440 )
Change subject: fmap.{c,h}: update copyright year and name ......................................................................
fmap.{c,h}: update copyright year and name
Looks like the year should be 2010 based on cros git history.
Signed-off-by: Nikolai Artemiev nartemiev@google.com Change-Id: I7c27e682bd09f7b1ba0398dc231b9360aed1c26b Reviewed-on: https://review.coreboot.org/c/flashrom/+/46440 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M fmap.c M fmap.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
diff --git a/fmap.c b/fmap.c index ca25651..2f34a5c 100644 --- a/fmap.c +++ b/fmap.c @@ -1,5 +1,5 @@ /* - * Copyright 2015, Google Inc. + * Copyright 2010, Google LLC. * Copyright 2018-present, Facebook Inc. * All rights reserved. * diff --git a/fmap.h b/fmap.h index be5f8bc..924e11f 100644 --- a/fmap.h +++ b/fmap.h @@ -1,5 +1,5 @@ /* - * Copyright 2015, Google Inc. + * Copyright 2010, Google LLC. * Copyright 2018-present, Facebook Inc. * All rights reserved. *
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Nikolai Artemiev (Code Review)