Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
PoroCYon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 )
Change subject: flashchips: Add Macronix MX25V4035F support
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Seems good, only minor things. […]
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73582/comment/f633714d_3a6e0401
PS1, Line 9671: {
: .eraseblocks = { {2 * 1024 * 1024, 1} },
: .block_erase = SPI_BLOCK_ERASE_60,
: }
The chip erase can also be performed with `SPI_BLOCK_ERASE_C7` […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137
Gerrit-Change-Number: 73582
Gerrit-PatchSet: 2
Gerrit-Owner: PoroCYon
p@pcy.be
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 20 Mar 2023 13:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment