Attention is currently required from: Felix Singer, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropriate variables with bool ......................................................................
Patch Set 13:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/0474d3e0_244d27cd PS7, Line 872: write_cmd = true; I finished taking a look at the patches, most look good and there's a few (like this one) for which there's stuff to be done. I expect my comments to be resolved soon: either update the changes accordingly, or link to follow-up commits that take care of my comments.
And there is really no need to write walls of text because of this change. Especially not when it's repeating generic arguments that don't even apply to this case.
I'm not sure if this is about my wall of text. I tried to de-escalate the situation, let me know what I could've done better. I don't mind writing walls of text, anyway.
As Anastasia pointed out: "Renaming only comes up for this one file (two variables in here), not for every patch in the chain." I think it would have taken less than 1% of the time we spent to discuss this to change this one commit.
I agree, in most cases it's much easier to just change small things right away than to spend time discussing them. Even creating a follow-up commit to rename two variables would've been better than to start a discussion that quickly became sour.
There seems to be not a single patch in this chain that depends on it, so no rebase necessary (`rebase` btw. is a Git command, Git can do that for us, no hard manual work needed, unless there are conflicts, which are rare).
I was referring to conflicts that require manual rebases. I agree that these changes are not that troublesome, though.
-
Angel Pons (Code Review)