Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS3:
Earlier it complained on some type mismatches in ich_descriptors_tool
NVM I see it...
BTW [213/270] Compiling C object util/ich_descriptors_tool/ich_descriptors_tool.p/ich_descriptors_tool.c.o ../util/ich_descriptors_tool/ich_descriptors_tool.c: In function 'dump_file': ../util/ich_descriptors_tool/ich_descriptors_tool.c:89:10: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare] 89 | if (ret != file_len) { | ^~ ../util/ich_descriptors_tool/ich_descriptors_tool.c: In function 'main': ../util/ich_descriptors_tool/ich_descriptors_tool.c:262:10: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare] 262 | if (len >= ICH_FREG_BASE(desc.region.FLREGs[3]) + 6 && pMAC[0] != 0xff) | ^~