Change in flashrom[master]: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size... - flashrom-gerrit

7 Jun 2021


      Attention is currently required from: Nico Huber, Thomas Heijligen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55117 )
Change subject: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55117/comment/c62af569_934ef5d4 
PS3, Line 7: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations
...
It's just too long, how about […]
could this just be squashed into the previous patch that introduced it earlier in the serires? Seems reasonable to have it introduced and used in the same patch.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84
Gerrit-Change-Number: 55117
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Xiang W wxjstz@126.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Mon, 07 Jun 2021 04:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment