Change in flashrom[staging]: Add a convenient libflashrom interface - flashrom-gerrit

11 May 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/17946 )
Change subject: Add a convenient libflashrom interface
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
One last thing to bikeshed, otherwise LGTM.
https://review.coreboot.org/#/c/17946/10/flash.h
File flash.h:
PS10, Line 142: /* TODO: Agree on a name and convert all occurences.
I think the scope of this struct has grown beyond context of the flash chip. How about flashrom_ctx or flashrom_context?
-- 
To view, visit https://review.coreboot.org/17946
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00f169990830aa17b7dfae5eb74010d40c476181
Gerrit-PatchSet: 10
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes