Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81606?usp=email )
Change subject: Make sleep threshold for delays configurable ......................................................................
Patch Set 3:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/81606/comment/7d6bd934_c2352815 : PS2, Line 545: CONFIG_DELAY_MINIMUM_SLEEP_US ?= 100000
meson_options. […]
Done
File tests/udelay.c:
https://review.coreboot.org/c/flashrom/+/81606/comment/559241cb_26a68d48 : PS2, Line 45: udelay_test_short
For completeness, it would be good to build and run unit tests with few different settings: […]
Done, also needed to change the code a little to not generate spurious errors when it's set to zero.
https://review.coreboot.org/c/flashrom/+/81606/comment/f6d76b38_3abb2884 : PS2, Line 52: if (delay_us >= CONFIG_DELAY_MINIMUM_SLEEP_US)
why this condition is needed? […]
The test always takes at least as long to run as the chosen delay time, so 0.1ms seemed like a reasonable tradeoff between a meaninful delay and not wasting a lot of time running the test.
1ms still seems like an okay maximum if you wanted one that's more than the current value, though.
-
Peter Marheine (Code Review)