Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34945 )
Change subject: util/ich_descriptor_tool: use clang's style suggestion ......................................................................
util/ich_descriptor_tool: use clang's style suggestion
Tested on: FreeBSD clang version 8.0.1 (tags/RELEASE_801/final 366581) (based on LLVM 8.0.1) Target: x86_64-unknown-freebsd13.0
Change-Id: Ie80c4c4d70c8ccf357ba8e65f454fc4d4fa8c058 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/34945/1
diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index 2db0f62..9fcb2ba 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -152,7 +152,7 @@ const char *fn = NULL; const char *csn = NULL; enum ich_chipset cs = CHIPSET_ICH_UNKNOWN; - struct ich_descriptors desc = { 0 }; + struct ich_descriptors desc = { { 0 } };
while ((opt = getopt(argc, argv, "df:c:")) != -1) { switch (opt) {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/34945
to look at the new patch set (#2).
Change subject: util/ich_descriptors_tool: use clang's style suggestion ......................................................................
util/ich_descriptors_tool: use clang's style suggestion
Tested on: FreeBSD clang version 8.0.1 (tags/RELEASE_801/final 366581) (based on LLVM 8.0.1) Target: x86_64-unknown-freebsd13.0
Change-Id: Ie80c4c4d70c8ccf357ba8e65f454fc4d4fa8c058 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/34945/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/34945
to look at the new patch set (#3).
Change subject: util/ich_descriptors_tool: use clang's style suggestion ......................................................................
util/ich_descriptors_tool: use clang's style suggestion
Tested on amd64 with: FreeBSD clang version 8.0.1 (tags/RELEASE_801/final 366581) (based on LLVM 8.0.1)
gcc version 9.1.0 (FreeBSD Ports Collection)
Change-Id: Ie80c4c4d70c8ccf357ba8e65f454fc4d4fa8c058 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/34945/3
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34945 )
Change subject: util/ich_descriptors_tool: use clang's style suggestion ......................................................................
Patch Set 3:
cc -Os -Wall -Wshadow -Werror -MMD -MP -MF .dep/ich_descriptors_tool.o.d -D ICH_DESCRIPTORS_FROM_DUMP_ONLY -I../../ -I. -o .obj/ich_descriptors_tool.o -c ich_descriptors_tool.c ich_descriptors_tool.c:155:34: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] struct ich_descriptors desc = { 0 }; ^ {}
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34945 )
Change subject: util/ich_descriptors_tool: use clang's style suggestion ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34945 )
Change subject: util/ich_descriptors_tool: use clang's style suggestion ......................................................................
Patch Set 3: Code-Review-1
This would collide with -Wmissing-field-initializers (part of -Wextra in GCC) that we are about to enable for flashrom.
IIRC, the behaviour also changed in Clang 9.
-
David Hendricks (Code Review) -
Idwer Vollering (Code Review)
-
Nico Huber (Code Review)