Change in flashrom[master]: libflashrom: Avoid using the global layout - flashrom-gerrit

19 Jun 2021


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Daniel Campello.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54284 )
Change subject: libflashrom: Avoid using the global layout
......................................................................
Patch Set 5:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/54284/comment/91d62d63_79ac3de3 
PS3, Line 527: flashrom_layout_new(&l)
...
perhaps remove the intermediate and use `layout` directly? seems like `l` can leak here?
Done
Thanks for spotting. Using `layout` would only achieve that we leak a
pointer to a leaked structure, though. We still need to clean up on
the error path, so I kept the local `l`.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/54284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic48c9e73a3d00782f638f6ff41b620910b24ab6f
Gerrit-Change-Number: 54284
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Comment-Date: Sat, 19 Jun 2021 15:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment