Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/25683 )
Change subject: Add support for National Instruments USB-845x devices ......................................................................
Patch Set 25:
Patch Set 25: Code-Review+2
(4 comments)
I'm willing to merge this as is. The automatic voltage adaption seems a little rough on the edges, though. Generally, such a feature would belong into a higher level of flashrom. And then there is the possibility that the user didn't connect the chip directly to the programmer...
Anyway, this already adds a lot to flashrom's traits. I'll try to rebase it in Gerrit. If that works and there are no further comments, I'll try to merge it this weekend.
Good timing, I will fix the outstanding issues today/tomorrow. I agree with the adding option for the IO voltage override.