Marc Schink has posted comments on this change. ( https://review.coreboot.org/28087 )
Change subject: Add initial J-Link SPI programmer ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c:
https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344:
Ack, I checked their code... not that they cared to document […]
I will add a comment to the documentation, thanks for the pointer ;)
https://review.coreboot.org/#/c/28087/4/jlink_spi.c File jlink_spi.c:
https://review.coreboot.org/#/c/28087/4/jlink_spi.c@214 PS4, Line 214: ) {
same here...
Necessary since an empty string will be parsed to '0'. Maybe this should be fixed in libjaylink, not sure.
-
Marc Schink (Code Review)