Attention is currently required from: Evan Benn.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69263 )
Change subject: tests: Mock the mode_t variant of open
......................................................................
Patch Set 4:
(1 comment)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/69263/comment/55d30bcf_fecbc935
PS4, Line 103: mode_t mode = 0;
: if (flags & O_CREAT) {
: va_list ap;
: va_start(ap, flags);
: mode = va_arg(ap, mode_t);
: va_end(ap);
: }
This code repeats for all variants of open wraps, can this code go to mock_open?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c134e6d36a248d0f51985e389085a9e585fb83d
Gerrit-Change-Number: 69263
Gerrit-PatchSet: 4
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Evan Benn
evanbenn@google.com
Gerrit-Comment-Date: Sun, 13 Nov 2022 22:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment