Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60845 )
Change subject: nicintel_eeprom: remove unused rget_io_perms() ......................................................................
nicintel_eeprom: remove unused rget_io_perms()
The nicintel_eeprom programmer does not use x86 IO Ports. Remove the dependency to it.
Change-Id: I5fd42572fd29f5d7fd749c2836eac3e68c947946 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/60845 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile M nicintel_eeprom.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index da38d6b..93fc657 100644 --- a/Makefile +++ b/Makefile @@ -128,7 +128,6 @@ CONFIG_ATAPROMISE \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ - CONFIG_NICINTEL_EEPROM \ CONFIG_NICINTEL_SPI \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index 7b92958..ea0e768 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -35,7 +35,6 @@ #include "spi.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h"
@@ -462,9 +461,6 @@
static int nicintel_ee_init(void) { - if (rget_io_perms()) - return 1; - struct pci_dev *dev = pcidev_init(nics_intel_ee, PCI_BASE_ADDRESS_0); if (!dev) return 1;