[XS] Change in flashrom[main]: flashrom: Change chip unlock error to warning - flashrom-gerrit

7 May 2024


      Attention is currently required from: Brian Norris, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82175?usp=email )
Change subject: flashrom: Change chip unlock error to warning
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/82175/comment/baff810b_55255988 :
PS1, Line 2134: ret
...
to help answer Anastasia's question: this is the only place `unlock_flash_wp()`'s return code is che […]
Ah I see. And there is a fall back anyway (with its return code not checked :) )
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/82175?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I14c3b55e387443909ca1efab2fc1901f87dd66d6
Gerrit-Change-Number: 82175
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Brian Norris briannorris@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen roccochen@google.com
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Brian Norris briannorris@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Tue, 07 May 2024 09:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Brian Norris briannorris@chromium.org
Gerrit-MessageType: comment