Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: raiden_debug_spi: Remove fixme with explanation ......................................................................
raiden_debug_spi: Remove fixme with explanation
The raiden_debug_spi programmer will query the connected USB devices and match against criteria other than the pid rather than iterate through the vid:pid table. The fixme has been updated to explain why the dev_entry table is empty.
TICKET: https://ticket.coreboot.org/issues/394
BUG=b:253320285 TEST=build
Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6 Signed-off-by: Liam Flaherty liamflaherty@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/68364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org --- M raiden_debug_spi.c 1 file changed, 28 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved
diff --git a/raiden_debug_spi.c b/raiden_debug_spi.c index fb068c8..517b173 100644 --- a/raiden_debug_spi.c +++ b/raiden_debug_spi.c @@ -350,7 +350,11 @@ #include <string.h> #include <unistd.h>
-/* FIXME: Add some programmer IDs here */ +/* + * Table is empty as raiden_debug_spi matches against the class and + * subclass of the connected USB devices, rather than looking for a + * device with a specific vid:pid. + */ static const struct dev_entry devs_raiden[] = { {0}, };