Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27106 )

Change subject: [WIP]layout.c: Use a linked lists for layout
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/27106/2/cli_classic.c
File cli_classic.c:

https://review.coreboot.org/#/c/27106/2/cli_classic.c@556
PS2, Line 556: /* if (layoutfile) { */
             : 	/* 	layout = get_global_layout(); */
             : 	/* } else  */
to remove


https://review.coreboot.org/#/c/27106/2/flashrom.c
File flashrom.c:

https://review.coreboot.org/#/c/27106/2/flashrom.c@a2222
PS2, Line 2222: 
does no longer exist... so does the normalize_romentries still make sense?


https://review.coreboot.org/#/c/27106/2/flashrom.c@2226
PS2, Line 2226: lash->layout
when doing --ifd this is unintialised...



-- 
To view, visit https://review.coreboot.org/27106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e
Gerrit-Change-Number: 27106
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Thu, 14 Jun 2018 17:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No