Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 )
Change subject: Add support for Intel Emmitsburg PCH
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57635/comment/e94bb73d_0274eaa8
PS1, Line 945: if (content->ISL <= 139)
Can there be Emmitsburg IFDs with less than 80 straps? I'd check for `content->ISL < 80` somewhere, either here or in a `warn_peculiar_desc()` call (which could also check `content->ISL != 80 && content->ISL != 139`)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451
Gerrit-Change-Number: 57635
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Tue, 14 Sep 2021 08:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment