Attention is currently required from: Fabian Groffen, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email )
Change subject: dummyflasher: assign address of function for LLVM
......................................................................
Patch Set 1:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/83262/comment/1ea74013_8388dd1e?usp... :
PS1, Line 972: &
Why this is not needed for all other function pointers? (I feel like I am missing something. They are declared the same in struct spi_master in include/programmer.h)
I know you are fixing something real, just want to understand.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952
Gerrit-Change-Number: 83262
Gerrit-PatchSet: 1
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Fabian Groffen
grobian@gentoo.org
Gerrit-Comment-Date: Tue, 02 Jul 2024 03:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No