Attention is currently required from: Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64385 )
Change subject: tests: add "stdlib.h" to the default includes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Just checking: why adding this header? Where it is used? […]
It is used for malloc(), free(), etc. IMO using #includ <stdlib.h> in better than using the compiler arg "-includestdlib.h"
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43fb02b2cff29d964e92556ad656cdda74a45ef2
Gerrit-Change-Number: 64385
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 23 May 2022 16:37:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment