Attention is currently required from: Martin L Roth, Thomas Heijligen, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74953 )
Change subject: flashrom: Update 'sb600' references to 'amd'
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File amd_spi.c:
https://review.coreboot.org/c/flashrom/+/74953/comment/89920bd9_23e434aa
PS1, Line 156: amd_spibar
Minor: Since these function parameters are stack local to the working function, how about just dropping the prefix?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1200ef25b6765f809c754ae0adcdcfe680c202fd
Gerrit-Change-Number: 74953
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 22 May 2023 02:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment