Attention is currently required from: Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62844 )
Change subject: tests: add more mock wrappers ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62844/comment/8a0b7091_c9c3cc56 PS1, Line 9: This change allows for tests to run when the compiler is inlining some : other interfaces.
While I know what you mean here about clang but can you elaborate in a similar fashion to the corebo […]
Even when I did read the coreboot patch, it did not help me figure out what was actually needed. What I did end up doing was to use `nm` on each of the compliled object files that were giving me troubles and finding the appropriate undefined symbols to be mocked.
* __fgets_chk was being used instead of fgets in get_max_kernel_buf_size() on linux_spi.c * __vfprintf_chk was being used instead of fprintf in disable_power_management() on power.c * __open64_2() was being used instead of open() in i2c_open_path() on i2c_helper_linux.c
-
Daniel Campello (Code Review)