Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection
......................................................................
Patch Set 7:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/48d9819a_60ecaba3
PS2, Line 98: # 'deps' : list[dep], # fallback: []
It's possible but quite complicated to put an optional external dependency together with an source f […]
Ack
https://review.coreboot.org/c/flashrom/+/63724/comment/10ffb954_264d326a
PS2, Line 427: elif selected and available
I found non nested if statements easier. […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib44b26e3748fc71f116184082b4aed0bb208b4c1
Gerrit-Change-Number: 63724
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 27 Apr 2022 00:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment
Peter Marheine (Code Review)