Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen.
Hsuan-ting Chen has posted comments on this change by Hsuan-ting Chen. ( https://review.coreboot.org/c/flashrom/+/83219?usp=email )
Change subject: tests/selfcheck.c: Include the missing header lifecycle.h ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: I will get a build error in the CHROMIUM repository:
``` ../tests/selfcheck.c:155:9: error: return type defaults to ‘int’ [-Werror=implicit-int] 155 | SKIP_TEST(selfcheck_board_matches_table) | ^~~~~~~~~ ../tests/selfcheck.c:155:9: error: no previous prototype for ‘SKIP_TEST’ [-Werror=missing-prototypes] ../tests/selfcheck.c: In function ‘SKIP_TEST’: ../tests/selfcheck.c:155:9: error: type of ‘selfcheck_board_matches_table’ defaults to ‘int’ [-Werror=implicit-int] ../tests/selfcheck.c:157: error: expected ‘{’ at end of input ../tests/selfcheck.c:157: error: control reaches end of non-void function [-Werror=return-type] cc1: all warnings being treated as errors [109/148] Generating doc/documentation with a custom command ninja: build stopped: subcommand failed. ```
However, I cannot reproduce this error in the UPSTREAM version.
Regardless, adding this change makes sense to me – as long as we need it, we should include it.