Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83970?usp=email )
Change subject: flashchips: Update test status for Fuldan FM25Q08 and FM25Q128
......................................................................
Patch Set 1:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83970/comment/a2b7e6d8_9147e480?usp... :
PS1, Line 6243: { .probe = NT, .read = OK, .erase = OK, .write = OK },
Did you mean that to say that only Read operation is tested?
You need to use the macro `TEST_OK_PR` (all options are in /include/flash.h).
Probing is done with any operation anyway, so you also tested it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83970?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib3c94f03a132a912bb4bb9d36e8783f4468587c4
Gerrit-Change-Number: 83970
Gerrit-PatchSet: 1
Gerrit-Owner: Samantaz Fox
coding@samantaz.fr
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Samantaz Fox
coding@samantaz.fr
Gerrit-Comment-Date: Mon, 19 Aug 2024 10:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No