[L] Change in flashrom[master]: doc: Add build instructions - flashrom-gerrit

8 Mar 2023


      Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Anastasia Klimchuk, Alexander Goncharov.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File doc/developers_doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/9cee035c_02e428b6 
PS3, Line 175: .. todo:: Write a sphinx extension to render ``meson_options.txt`` here
...
ok, `meson configure` has different behavior with and without a build directory. […]
Okay, SGTM.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Wed, 08 Mar 2023 22:29:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Peter Marheine pmarheine@chromium.org
Gerrit-MessageType: comment