Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Victor Lim.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81970?usp=email )
Change subject: <Flashrom SPI NOR>: adding a few new SPI NOR part numbers
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Victor, this is amazing, thank you so much for adding and updating so many chips! […]
+1 Thank you Victor for adding all these chips!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81970/comment/90c2f7a2_428f544c :
PS1, Line 6998:
Just a small thing but please ensure that the new entries are indented using tabs only.
https://review.coreboot.org/c/flashrom/+/81970/comment/516b3ced_d414beb0 :
PS1, Line 7278: acts like SEC
Should this be `acts like TB`?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81970?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1526eed830845d5391ca14c7fd3ac58a5aee71f2
Gerrit-Change-Number: 81970
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim
victorswlim@yahoo.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Victor Lim
victorswlim@yahoo.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 23 Apr 2024 01:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment